Improve async performance, allow specifying an executor#52
Merged
Conversation
To keep the Java thread as unblocked as possible.
Still keep the default of the `ForkJoinPool.commonPool` so there are no breaking changes.
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 467a7fe |
giarc3
approved these changes
Mar 24, 2026
Co-authored-by: Craig Colegrove <34786857+giarc3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #29 and fixes #13.
#29 is fixed via creating a recursive
thenComposecompletableFuturechain, which checks the rust future and schedules a future check, allowing for full async performance on the Java side instead of blocking the thread.#13 is fixed by changing the internal async call functions to take a executor (and use it for its
*AsyncJava API calls), and then externally generating a version of each async function that takes an executor and passes it to the internal one. The current function signature is still generated, and it internally calls for theForkJoinPool.commonPool()and passes that to the new method.